This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
feat: extend plugin API supports close widget #355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
=======================================
Coverage 18.38% 18.38%
=======================================
Files 514 514
Lines 51617 51638 +21
Branches 640 640
=======================================
+ Hits 9488 9493 +5
- Misses 42094 42110 +16
Partials 35 35
|
KaWaite
reviewed
Nov 15, 2022
KaWaite
reviewed
Nov 15, 2022
KaWaite
approved these changes
Nov 16, 2022
rot1024
approved these changes
Nov 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close reearth/reearth-visualizer#365
Overview
Enable plugin to close the main ui widget.
What I've done
Implement the API:
What I haven't done
How I tested
Tested with plugin:
Screenshot
Which point I want you to review particularly
Memo