Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: correct flyToGround destination camera #356

Merged
merged 5 commits into from
Nov 18, 2022

Conversation

airslice
Copy link
Contributor

@airslice airslice commented Nov 14, 2022

Overview

The flyToGround API used a wrong destination camera.

What I've done

Correct the destination camera using the param camera.

What I haven't done

How I tested

Test with plugin pedestrain.

Screenshot

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 8172f73
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6374464638b5510009343aee
😎 Deploy Preview https://deploy-preview-356--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #356 (8172f73) into main (ec0b81d) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   18.37%   18.38%           
=======================================
  Files         514      514           
  Lines       51622    51617    -5     
  Branches      640      640           
=======================================
+ Hits         9486     9488    +2     
+ Misses      42101    42094    -7     
  Partials       35       35           
Impacted Files Coverage Δ
...nents/molecules/Visualizer/Engine/Cesium/common.ts 43.24% <33.33%> (+0.59%) ⬆️

@airslice airslice marked this pull request as ready for review November 16, 2022 01:20
@airslice airslice merged commit 2257586 into main Nov 18, 2022
@airslice airslice deleted the fix/fly-to-ground-wrong-position branch November 18, 2022 01:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants