Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: support 2d mode in navigator #360

Merged
merged 4 commits into from
Dec 13, 2022
Merged

feat: support 2d mode in navigator #360

merged 4 commits into from
Dec 13, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Nov 23, 2022

Overview

I supported 2d mode in navigator component.

What I've done

  • supported 2d mode in navigator
    • orbit
    • rotate
    • zoomin/out

What I haven't done

  • adding help modal that is displayed when ? button is clicked
    • I will implement it another PR

How I tested

  • enable 2d mode
  • operate navigator

Screenshot

support-2d-navigator.mp4

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit f309835
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/639823cffa112c000959c498
😎 Deploy Preview https://deploy-preview-360--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #360 (f309835) into main (2871edd) will increase coverage by 6.19%.
The diff coverage is 60.72%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   18.42%   24.61%   +6.19%     
==========================================
  Files         524      596      +72     
  Lines       53466    62659    +9193     
  Branches      643     1243     +600     
==========================================
+ Hits         9849    15422    +5573     
- Misses      43585    47191    +3606     
- Partials       32       46      +14     
Impacted Files Coverage Δ
src/core/Crust/Infobox/index.tsx 0.00% <0.00%> (ø)
src/core/Crust/Plugins/index.tsx 0.00% <0.00%> (ø)
src/core/Crust/Widgets/index.tsx 0.00% <0.00%> (ø)
src/core/Crust/index.tsx 0.00% <0.00%> (ø)
src/core/Map/hooks.ts 0.00% <0.00%> (ø)
src/core/Map/index.tsx 0.00% <0.00%> (ø)
src/core/Map/types/index.ts 0.00% <0.00%> (ø)
src/core/Visualizer/index.tsx 0.00% <0.00%> (ø)
src/core/engines/Cesium/Cluster.tsx 0.00% <0.00%> (ø)
src/core/engines/Cesium/Event.tsx 0.00% <0.00%> (ø)
... and 68 more

@keiya01 keiya01 merged commit 595dd53 into main Dec 13, 2022
@keiya01 keiya01 deleted the feat/support-2d-navigator branch December 13, 2022 10:15
keiya01 pushed a commit that referenced this pull request Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants