Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: rename animation option to withoutAnimation in lookAt #361

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Nov 23, 2022

Overview

I added animation option to lookAt function. This option makes lookAt function work without animation.
But the name that called animation is miss context, so I fixed this name to withoutAnimation.
https://github.com/reearth/reearth-web/pull/338/files#diff-0b5055db5c2f9046c0a43a5d935daac31c9eff33ee864fe1f90cc7f890932e09R84

What I've done

What I haven't done

How I tested

Screenshot

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 6289824
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/637d81f99e51e3000aecb266
😎 Deploy Preview https://deploy-preview-361--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #361 (6289824) into main (abb4ed9) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage   18.39%   18.39%           
=======================================
  Files         514      514           
  Lines       51644    51644           
  Branches      640      640           
=======================================
  Hits         9498     9498           
  Misses      42111    42111           
  Partials       35       35           
Impacted Files Coverage Δ
...molecules/Visualizer/Engine/Cesium/useEngineRef.ts 68.51% <0.00%> (ø)
src/components/molecules/Visualizer/Engine/ref.ts 0.00% <0.00%> (ø)

@keiya01 keiya01 merged commit 846a6e2 into main Nov 23, 2022
@keiya01 keiya01 deleted the fix/rename-animation-option-lookAt branch November 23, 2022 06:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants