This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
I fixed the bug that does not render the layer even when updating the property for layer.
This is because, the old system is updated every clock event is occurred but the new layer system disable this behavior for performance, so we need to call
scene.requestRender
manually.Also I fixed resium in reearth/resium#568.
TODO: I will update the resium when @rot1024 -san publish it.What I haven't done
How I tested
Screenshot
Which point I want you to review particularly
Memo