Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: rendering bug in new layer system #375

Merged
merged 4 commits into from
Dec 15, 2022
Merged

fix: rendering bug in new layer system #375

merged 4 commits into from
Dec 15, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Dec 14, 2022

Overview

What I've done

I fixed the bug that does not render the layer even when updating the property for layer.
This is because, the old system is updated every clock event is occurred but the new layer system disable this behavior for performance, so we need to call scene.requestRender manually.
Also I fixed resium in reearth/resium#568.

TODO: I will update the resium when @rot1024 -san publish it.

What I haven't done

How I tested

  1. Open storybook
  2. Change the color of marker on storybook(That works)
  3. Change the coordinates of marker on storybook(That didn't work but currently that should work)

Screenshot

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Dec 14, 2022
@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 7e869d0
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/639ae0f02b1cbe0008dd0e52
😎 Deploy Preview https://deploy-preview-375--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@keiya01 keiya01 marked this pull request as ready for review December 15, 2022 01:13
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #375 (7e869d0) into main (4abbbac) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   24.53%   24.53%   -0.01%     
==========================================
  Files         597      597              
  Lines       62871    62880       +9     
  Branches     1243     1243              
==========================================
  Hits        15428    15428              
- Misses      47397    47406       +9     
  Partials       46       46              
Impacted Files Coverage Δ
src/core/engines/Cesium/hooks.ts 0.00% <0.00%> (ø)
src/core/engines/Cesium/index.tsx 0.00% <0.00%> (ø)

package.json Outdated Show resolved Hide resolved
@keiya01 keiya01 enabled auto-merge (squash) December 15, 2022 08:54
@keiya01 keiya01 merged commit 172988e into main Dec 15, 2022
@keiya01 keiya01 deleted the fix/rendering-bugs branch December 15, 2022 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants