This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
feat: port the Box layer into the reearth/core #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
keiya01
changed the title
keiya01
changed the title
keiya01
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
- Coverage 24.71% 24.16% -0.56%
==========================================
Files 598 610 +12
Lines 63139 64736 +1597
Branches 1258 1258
==========================================
+ Hits 15605 15641 +36
- Misses 47488 49049 +1561
Partials 46 46
|
rot1024
suggested changes
Dec 15, 2022
keiya01
commented
Dec 15, 2022
keiya01
force-pushed
the
feat/add-box-to-core
branch
from
38fd1f8
to
2eb45b2
Compare
|
I've added onLayerEdit to context. |
keiya01
force-pushed
the
feat/add-box-to-core
branch
from
9c70d57
to
ec25f2f
Compare
|
I fixed the box layer event handling. |
rot1024
suggested changes
Dec 19, 2022
rot1024
suggested changes
Dec 20, 2022
rot1024
approved these changes
Dec 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
I have ported the Box layer into the reearth/core/features.
Also I have ported the clipping feature logic into Tileset component in the reearth/core/features.
What I haven't done
How I tested
Screenshot
Which point I want you to review particularly
Memo