Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: support multi feature for geojson #380

Merged
merged 2 commits into from
Dec 19, 2022
Merged

feat: support multi feature for geojson #380

merged 2 commits into from
Dec 19, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Dec 19, 2022

Overview

What I've done

I've supported the multi feature for geojson.
The multi feature includes MultiPoint, MultiLineString and MultiPolygon.

What I haven't done

How I tested

You can use the following sample geojson.

  1. Download the sample
  2. Set it to .storybook/public
  3. Set the path in core/engine/Cesium/index.stories.tsx

sample.zip

Screenshot

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Dec 19, 2022
@netlify
Copy link

netlify bot commented Dec 19, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 2c172f3
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/639fbae66620e900097399c4
😎 Deploy Preview https://deploy-preview-380--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #380 (2c172f3) into main (67bc52a) will decrease coverage by 0.00%.
The diff coverage is 20.93%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
- Coverage   24.71%   24.71%   -0.01%     
==========================================
  Files         598      598              
  Lines       63102    63143      +41     
  Branches     1255     1258       +3     
==========================================
+ Hits        15598    15605       +7     
- Misses      47458    47492      +34     
  Partials       46       46              
Impacted Files Coverage Δ
src/core/mantle/data/geojson.ts 32.83% <0.00%> (-33.84%) ⬇️
src/core/mantle/types/index.ts 100.00% <100.00%> (ø)

@keiya01 keiya01 merged commit d1ee59b into main Dec 19, 2022
@keiya01 keiya01 deleted the geojson-multi branch December 19, 2022 01:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants