Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: support entity array in flyTo on reearth/core #459

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Feb 15, 2023

Overview

What I've done

  • I added entity array support to flyTo like flyTo([layerId or featureId]).

What I haven't done

How I tested

Screenshot

flyTo([sphereId1, sphereId2])

Screen.Recording.2023-02-15.at.15.12.10.mov

flyTo(onlyOneFeatureId)

Screen.Recording.2023-02-15.at.11.05.16.mov

Which point I want you to review particularly

Memo

@keiya01 keiya01 requested a review from KaWaite February 15, 2023 06:15
@keiya01 keiya01 self-assigned this Feb 15, 2023
@netlify
Copy link

netlify bot commented Feb 15, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit cec74e7
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6410173946813000080b21fd
😎 Deploy Preview https://deploy-preview-459--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #459 (cec74e7) into main (31ba319) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   26.94%   26.93%   -0.01%     
==========================================
  Files         743      743              
  Lines       86707    86726      +19     
  Branches     1868     1868              
==========================================
  Hits        23360    23360              
- Misses      63251    63270      +19     
  Partials       96       96              
Impacted Files Coverage Δ
src/core/Crust/Plugins/hooks.ts 0.00% <0.00%> (ø)
src/core/Crust/Plugins/plugin_types.ts 0.00% <0.00%> (ø)
src/core/Map/types/index.ts 0.00% <0.00%> (ø)
src/core/engines/Cesium/useEngineRef.ts 54.91% <0.00%> (-2.44%) ⬇️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant