Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

refactor: use jotai instead of redux #68

Merged
merged 6 commits into from Aug 27, 2021
Merged

refactor: use jotai instead of redux #68

merged 6 commits into from Aug 27, 2021

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Aug 26, 2021

Since redux is an over-technology for the current use case, we will replace it with another state management library "jotai" to reduce the number of dependent libraries and optimize the bundled JS size.

  • Uninstall Redux and unused depencencies
  • Install jotai
  • Refactor components

@netlify
Copy link

netlify bot commented Aug 26, 2021

✔️ Deploy Preview for reearth-web ready!

🔨 Explore the source changes: 8d6e2fb

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61285392af9fc800076c7f69

😎 Browse the preview: https://deploy-preview-68--reearth-web.netlify.app

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #68 (8d6e2fb) into main (f981f91) will increase coverage by 0.12%.
The diff coverage is 48.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   57.98%   58.10%   +0.12%     
==========================================
  Files          42       40       -2     
  Lines         664      685      +21     
  Branches       94       96       +2     
==========================================
+ Hits          385      398      +13     
- Misses        236      245       +9     
+ Partials       43       42       -1     
Impacted Files Coverage Δ
src/auth/index.tsx 0.00% <0.00%> (ø)
src/gql/provider.tsx 5.55% <0.00%> (-0.33%) ⬇️
src/auth/hooks.ts 9.09% <8.33%> (-4.55%) ⬇️
src/state/index.ts 75.86% <75.86%> (ø)

KaWaite
KaWaite previously approved these changes Aug 26, 2021
Copy link
Member

@KaWaite KaWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
But I checked the preview env very briefly and it seems like Scene isn't selected on load so the right panel is blank when the Earth Editor is first opened.

@rot1024
Copy link
Member Author

rot1024 commented Aug 26, 2021

But I checked the preview env very briefly and it seems like Scene isn't selected on load so the right panel is blank when the Earth Editor is first opened.

I have also seen that behavior, but when I select a scene, the scene settings are displayed, and there is no noticeable abnormal behavior. This seems to be the expected behavior.

Copy link
Contributor

@issmail-basel issmail-basel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

Copy link
Member

@HideBa HideBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rot1024 rot1024 merged commit ea980cb into main Aug 27, 2021
@rot1024 rot1024 deleted the jotai branch August 27, 2021 11:35
keiya01 pushed a commit that referenced this pull request Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants