Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: camera property panel bugs #96

Merged
merged 8 commits into from Oct 5, 2021
Merged

fix: camera property panel bugs #96

merged 8 commits into from Oct 5, 2021

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Oct 5, 2021

  • Fix initial camera position property does not work
  • FIx camera field panel on property pane:
    • Fix value display of heading, pitch, and roll (radian -> degree)
    • Jump button would not work
    • Camera would not move when input value has been changed
    • Camera would not be reverted when capturing is canceled

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #96 (d2e5fb5) into main (15df163) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   53.43%   53.43%           
=======================================
  Files          48       48           
  Lines         889      889           
  Branches      117      117           
=======================================
  Hits          475      475           
  Misses        364      364           
  Partials       50       50           

@netlify
Copy link

netlify bot commented Oct 5, 2021

❌ Deploy Preview for reearth-web failed.

🔨 Explore the source changes: d729a43

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/615bf8680ce11e0007a0a8af

@netlify
Copy link

netlify bot commented Oct 5, 2021

❌ Deploy Preview for reearth-web failed.

🔨 Explore the source changes: d2e5fb5

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/615bf8b08ae66400077980da

@rot1024 rot1024 merged commit 2c3eaab into main Oct 5, 2021
@rot1024 rot1024 deleted the fix/camera-init-pos branch October 5, 2021 07:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant