Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development error occurs when updating or DnD layers #331

Closed
airslice opened this issue Aug 24, 2022 · 0 comments
Closed

Development error occurs when updating or DnD layers #331

airslice opened this issue Aug 24, 2022 · 0 comments
Labels
bug Something isn't working frontend

Comments

@airslice
Copy link
Contributor

airslice commented Aug 24, 2022

Describe the bug

  • When run reearth-web locally and update layers data when there's multiple layer exist come out develop error reearth_draggable is already a registered property (addProperty issue)
  • When run reearth-web locally and try dnd layers comes out develop error time is required. (getValue issue)

Notice:

Questions:

  • Why don't we need to check if one property is exists or not before?

To Reproduce
Steps to reproduce the behavior:

  1. Run reearth-web locally.
  2. Do any of these actions: (most likely any behavior triggers a refetch?)
  • Add more than one marker (or other primitive).
  • Update any layer's property value.
  • Reorder layer from left pane.
  1. Got develop error message from console. (reearth_draggable is already a registered property.)
  2. Refresh page and try dnd on any layer.
  3. Got develop error message from console. (time is required.)

Expected behavior
Should not have these error throw out.

Screenshots
image
image

Desktop (please complete the following information):

  • OS: [macOS]
  • Browser [chrome]
  • Version [104.0.5112.101]

Additional context
Add any other context about the problem here.

@airslice airslice added bug Something isn't working frontend labels Aug 24, 2022
pyshx added a commit that referenced this issue Apr 17, 2023
* custom-terrain-url

* update

* Bug fix

* Revert "Bug fix"

This reverts commit 7b773b4c4561844b1ace1ca26a240bc367ff36f0.

* fix: remove get-pixels dependency and used CanvasAPI for PNG conversion to multidimensional array

* remove comments and logging statements

* update

* fix

* remove get-pixels

* relocated the formatting helper statements

* fix

* remove gsi terrain

* refactor

Co-authored-by: nina992 <nouralali992@gmail.com>
Co-authored-by: rot1024 <aayhrot@gmail.com>
Co-authored-by: Piyush Chauhan <piyushchauhan1004@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
No open projects
Re:Earth Dev Kanban v2
Bugs and features-requirement
Development

No branches or pull requests

1 participant