This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: development error occurs when updating or DnD layers #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
airslice
changed the title
fix: attache tag when it already exists
fix: attach cesium tag when it already exists
Aug 24, 2022
airslice
changed the title
fix: attach cesium tag when it already exists
fix: attach cesium tag error when it already exists
Aug 24, 2022
Codecov Report
@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 16.23% 16.26% +0.02%
==========================================
Files 489 491 +2
Lines 47203 47521 +318
Branches 509 515 +6
==========================================
+ Hits 7664 7728 +64
- Misses 39521 39776 +255
+ Partials 18 17 -1
|
rot1024
approved these changes
Aug 24, 2022
rot1024
force-pushed
the
fix/error-when-add-cesium-tag
branch
from
August 25, 2022 10:14
063cf1a
to
8b730bd
Compare
…earth-web into fix/error-when-add-cesium-tag
airslice
changed the title
fix: attach cesium tag error when it already exists
fix: development error occurs when updating or DnD layers
Aug 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
reearth_draggable is already a registered property.
.This occurs when the cesium tag bag
addProperty
method been called but there's the property exists.Ref: https://cesium.com/learn/cesiumjs/ref-doc/PropertyBag.html?classFilter=PropertyBag#addProperty
time is required
.Issue here: reearth/reearth#331
What I've done
Remove the property before add it if it exists.
Add
new JulianDate()
as the firest param togetValue
.What I haven't done
How I tested
Add multiple primitivies.
DnD layers.
Screenshot
Which point I want you to review particularly
Memo