Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: development error occurs when updating or DnD layers #299

Merged
merged 11 commits into from Aug 26, 2022

Conversation

airslice
Copy link
Contributor

@airslice airslice commented Aug 24, 2022

Overview

  1. When adding multiple primitivies into visualizer (or update any property when multiple primitivies exists) comes out error like reearth_draggable is already a registered property..

This occurs when the cesium tag bag addProperty method been called but there's the property exists.
Ref: https://cesium.com/learn/cesiumjs/ref-doc/PropertyBag.html?classFilter=PropertyBag#addProperty

  1. When DnD layers on dev env comes out development error time is required.

Issue here: reearth/reearth#331

What I've done

  • Remove the property before add it if it exists.

    • I didn't find something like updateProperty from the docs so i delete it and then add it to make sure it got the latest value.
  • Add new JulianDate() as the firest param to getValue.

What I haven't done

How I tested

Add multiple primitivies.
DnD layers.

Screenshot

image

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Aug 24, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 6e4c964
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/630830e88496fe0009eb713c
😎 Deploy Preview https://deploy-preview-299--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@airslice airslice changed the title fix: attache tag when it already exists fix: attach cesium tag when it already exists Aug 24, 2022
@airslice airslice changed the title fix: attach cesium tag when it already exists fix: attach cesium tag error when it already exists Aug 24, 2022
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #299 (6e4c964) into main (a0a03ef) will increase coverage by 0.02%.
The diff coverage is 13.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   16.23%   16.26%   +0.02%     
==========================================
  Files         489      491       +2     
  Lines       47203    47521     +318     
  Branches      509      515       +6     
==========================================
+ Hits         7664     7728      +64     
- Misses      39521    39776     +255     
+ Partials       18       17       -1     
Impacted Files Coverage Δ
src/components/atoms/TabSection/index.tsx 0.00% <0.00%> (ø)
...PluginAccordion/PluginAccordionItem/itemHeader.tsx 0.00% <0.00%> (ø)
.../Settings/Project/Plugin/PluginAccordion/index.tsx 0.00% <0.00%> (ø)
...Section/PluginInstall/MarketplacePublish/index.tsx 0.00% <0.00%> (ø)
...nSection/PluginInstall/PluginInstallCardButton.tsx 0.00% <0.00%> (ø)
...oject/Plugin/PluginSection/PluginInstall/index.tsx 0.00% <0.00%> (ø)
...es/Settings/Project/Plugin/PluginSection/index.tsx 0.00% <0.00%> (ø)
...onents/molecules/Settings/SettingsHeader/index.tsx 0.00% <0.00%> (ø)
...ponents/organisms/Settings/Project/Plugin/hooks.ts 0.00% <0.00%> (ø)
...onents/organisms/Settings/Project/Plugin/index.tsx 0.00% <0.00%> (ø)
... and 8 more

@airslice airslice added the bug Something isn't working label Aug 24, 2022
@airslice airslice marked this pull request as ready for review August 24, 2022 04:49
@rot1024 rot1024 force-pushed the fix/error-when-add-cesium-tag branch from 063cf1a to 8b730bd Compare August 25, 2022 10:14
@airslice airslice changed the title fix: attach cesium tag error when it already exists fix: development error occurs when updating or DnD layers Aug 26, 2022
@airslice airslice merged commit efd0793 into main Aug 26, 2022
@airslice airslice deleted the fix/error-when-add-cesium-tag branch August 26, 2022 02:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
2 participants