Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add 3D OSM building tiles #340

Merged
merged 4 commits into from Sep 14, 2022
Merged

feat(server): add 3D OSM building tiles #340

merged 4 commits into from Sep 14, 2022

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Sep 13, 2022

Overview

OSM Buildings is a 3D buildings layer covering the entire world. It's available as a 3D Tileset on Cesium.
we modified reearth back end in way that allows the user to add OSM building 3d Tileset as a layer in his project by providing him with an interface to chose which tiles to show on the map.

What I've done

  • modify manifes.yml and add the new attributes related to 3D OSM building tiles.
  • add the Japanese translation to manifest.ja.yml

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Design

https://www.figma.com/file/bdnfDaGXGoNfUws4y7JItl/Re%3AEarth-UI-Gamma?node-id=11576%3A179143

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #340 (d87682a) into main (b652c80) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   35.72%   35.72%           
=======================================
  Files         339      339           
  Lines       30202    30202           
=======================================
  Hits        10789    10789           
  Misses      18369    18369           
  Partials     1044     1044           

@nina992 nina992 marked this pull request as ready for review September 13, 2022 01:48
server/pkg/builtin/manifest_ja.yml Outdated Show resolved Hide resolved
server/pkg/builtin/manifest_ja.yml Outdated Show resolved Hide resolved
server/pkg/builtin/manifest_ja.yml Outdated Show resolved Hide resolved
server/pkg/builtin/manifest.yml Outdated Show resolved Hide resolved
server/pkg/builtin/manifest.yml Outdated Show resolved Hide resolved
@rot1024 rot1024 changed the title feat: add 3D OSM building tiles feat(server): add 3D OSM building tiles Sep 13, 2022
nina992 and others added 2 commits September 13, 2022 11:11
Co-authored-by: rot1024 <aayhrot@gmail.com>
Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
@nina992 nina992 merged commit b521326 into main Sep 14, 2022
@nina992 nina992 deleted the osm-tile branch September 14, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants