Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Japanese typo error #351

Merged
merged 3 commits into from Oct 24, 2022
Merged

fix(server): Japanese typo error #351

merged 3 commits into from Oct 24, 2022

Conversation

lavalse
Copy link
Member

@lavalse lavalse commented Oct 7, 2022

Overview

image

What I've done

fix typo mistake

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@lavalse lavalse requested a review from KaWaite October 7, 2022 06:53
@lavalse lavalse requested a review from HideBa as a code owner October 7, 2022 06:53
@lavalse lavalse changed the title fix japanese typo error Fix: japanese typo error Oct 7, 2022
@github-actions github-actions bot added the server label Oct 7, 2022
@lavalse lavalse self-assigned this Oct 7, 2022
@lavalse lavalse changed the title Fix: japanese typo error fix: japanese typo error Oct 14, 2022
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #351 (583a3e0) into main (cee2b2b) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 583a3e0 differs from pull request most recent head 73f851f. Consider uploading reports for the commit 73f851f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   35.64%   35.71%   +0.06%     
==========================================
  Files         339      339              
  Lines       30236    30254      +18     
==========================================
+ Hits        10778    10805      +27     
+ Misses      18408    18399       -9     
  Partials     1050     1050              
Impacted Files Coverage Δ
server/internal/infrastructure/mongo/tag.go 0.00% <0.00%> (ø)
server/internal/infrastructure/mongo/scene.go 0.00% <0.00%> (ø)
server/internal/infrastructure/mongo/plugin.go 0.00% <0.00%> (ø)
server/internal/infrastructure/mongo/dataset.go 0.00% <0.00%> (ø)
server/internal/infrastructure/mongo/property.go 0.00% <0.00%> (ø)
server/internal/infrastructure/mongo/workspace.go 0.00% <0.00%> (ø)
...er/internal/infrastructure/mongo/dataset_schema.go 0.00% <0.00%> (ø)
...r/internal/infrastructure/mongo/property_schema.go 0.00% <0.00%> (ø)
server/internal/infrastructure/mongo/layer.go 8.49% <0.00%> (+1.85%) ⬆️
server/internal/infrastructure/mongo/container.go 6.89% <0.00%> (+1.95%) ⬆️
... and 4 more

@lavalse lavalse changed the title fix: japanese typo error fix(server): Japanese typo error Oct 24, 2022
@lavalse lavalse enabled auto-merge (squash) October 24, 2022 09:09
@lavalse lavalse merged commit d0292ce into main Oct 24, 2022
@lavalse lavalse deleted the fix-typo-error branch October 24, 2022 09:13
pyshx pushed a commit that referenced this pull request Apr 17, 2023
* feat: plugin api scene public

* refactor: redefine as inEditor

* refactor: renaming as `inEditor`

* refactor: component params

* refactor: rename function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants