Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): sandbox plugin iframe - alpha #399

Merged
merged 12 commits into from May 12, 2023

Conversation

airslice
Copy link
Contributor

@airslice airslice commented Apr 23, 2023

Overview

This PR adds experimental sandbox iframe for NLS.
Also can be used in plugin editor with url query ?useCore&useSandbox.

What I've done

  • Add useExperimentalSandbox
  • Add component SafeIFrame

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@airslice airslice requested a review from rot1024 as a code owner April 23, 2023 13:15
@github-actions github-actions bot added the web label Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #399 (62449ca) into main (c225652) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 62449ca differs from pull request most recent head 8cb5b57. Consider uploading reports for the commit 8cb5b57 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
+ Coverage   35.91%   35.93%   +0.01%     
==========================================
  Files         348      346       -2     
  Lines       31204    30960     -244     
==========================================
- Hits        11207    11125      -82     
+ Misses      18890    18739     -151     
+ Partials     1107     1096      -11     
Flag Coverage Δ
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

@airslice airslice merged commit d77fcb3 into main May 12, 2023
2 checks passed
@airslice airslice deleted the feat/experimental-sandbox-alpha branch May 12, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants