feat(web): add reearth ver support in profile header #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for reearth-web failed.
|
KaWaite
reviewed
May 18, 2023
web/declarations.d.ts
Outdated
| @@ -0,0 +1 @@ | |||
| declare let __APP_VERSION__: string; | |||
There was a problem hiding this comment.
We have a
declare global {
interface Window {
..
...
...
}
in our src/config/index.ts file. Not sure it makes sense to put this there too. If it doesn't, perhaps we can move the global declaration in to this new file so that we keep things tidy.
What do you think?
There was a problem hiding this comment.
You're right, I may have overlooked that global class exist here. ff919e2 should fix that.
KaWaite
reviewed
May 18, 2023
KaWaite
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces functionality to display the current application version in the profile header of the Reearth application, enhancing user awareness of the version they are currently utilizing.