Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Split code between beta and classic #434

Merged
merged 20 commits into from May 23, 2023
Merged

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented May 22, 2023

Overview

See the design doc for details.
Tl;dr splitting the code up in preparation for developing Re:Earth's new design that harnesses the New Layer System.

What I've done

  • Moved classic specific code in to the classic directory. Setup the beta directory structure.
  • The original plan was to have services in beta, but state, graphql, etc are shared services (and won't change much) so I preemptively moved it to src.
    Additional:
  • Installed rollup directly to get rid of an error in the vite.config file around the yaml plugin
  • Fixed husky's pre-commit issue when moving gql directory by making the lint-staged path web/xxxx, not xxxx

@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for reearth-web failed.

Name Link
🔨 Latest commit eb072be
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/646c60cab42877000702bbc7

@github-actions github-actions bot added the web label May 22, 2023
@KaWaite KaWaite closed this May 22, 2023
@KaWaite KaWaite reopened this May 22, 2023
@KaWaite KaWaite marked this pull request as ready for review May 22, 2023 07:42
@KaWaite KaWaite requested a review from keiya01 as a code owner May 22, 2023 07:42
@pyshx pyshx self-requested a review May 23, 2023 05:46
@KaWaite KaWaite merged commit a8a6803 into main May 23, 2023
2 of 7 checks passed
@KaWaite KaWaite deleted the feat/split-experimental branch May 23, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants