Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix git hook, ESLint and CI setting to work properly #443

Merged
merged 5 commits into from May 24, 2023

Conversation

isoppp
Copy link
Contributor

@isoppp isoppp commented May 24, 2023

Overview

This PR solves these problems.

  • yarn eslint will freeze while it's running.
  • Compared to old repository, there are some missing file
  • lint-staged does not catch any staged files when running git-hook

What I've done

What I haven't done

How I tested

Manually run yarn lint and yarn lint-staged in my local.
CI will be displayed in this PR.

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit 2d179de
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/646dbf109ad85300087e7245

@rot1024 rot1024 changed the title fix(web): fix git hook, eslint and CI setting to work properly ci(web): fix git hook, eslint and CI setting to work properly May 24, 2023
@rot1024 rot1024 changed the title ci(web): fix git hook, eslint and CI setting to work properly ci(web): fix git hook, ESLint and CI setting to work properly May 24, 2023
@pyshx pyshx changed the title ci(web): fix git hook, ESLint and CI setting to work properly ci: fix git hook, ESLint and CI setting to work properly May 24, 2023
@KaWaite KaWaite merged commit 7604be6 into reearth:main May 24, 2023
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants