Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): move visualizer to beta #460

Merged
merged 4 commits into from Jun 2, 2023
Merged

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Jun 1, 2023

Overview

What I've done

  • Storybook should work for core
  • You can see Visualizer is working in beta pages.
  • All path in core was replaced.

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Jun 1, 2023
@keiya01 keiya01 requested a review from KaWaite as a code owner June 1, 2023 10:13
@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit b99d40a
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64787a40ccc3dd00083d5b51
😎 Deploy Preview https://deploy-preview-460--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the web label Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #460 (b99d40a) into main (ef30ad0) will increase coverage by 2.15%.
The diff coverage is 30.02%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   24.63%   26.78%   +2.15%     
==========================================
  Files        1051     1261     +210     
  Lines      112111   140064   +27953     
  Branches     2140     3404    +1264     
==========================================
+ Hits        27613    37519    +9906     
- Misses      83394   101441   +18047     
  Partials     1104     1104              
Flag Coverage Δ
web-beta 24.06% <30.02%> (+3.92%) ⬆️
web-classic 24.06% <30.02%> (+3.92%) ⬆️
web-utils 24.06% <30.02%> (+3.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/beta/components/ContentPicker/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/DropHolder/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Filled/index.ts 0.00% <0.00%> (ø)
web/src/beta/components/NotFound/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Slide/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Slider/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Timeline/types.ts 0.00% <0.00%> (ø)
web/src/beta/core/Crust/Infobox/types.ts 0.00% <0.00%> (ø)
...core/Crust/Plugins/Plugin/ModalContainer/index.tsx 0.00% <0.00%> (ø)
...core/Crust/Plugins/Plugin/PopupContainer/index.tsx 0.00% <0.00%> (ø)
... and 187 more

... and 17 files with indirect coverage changes

@pyshx pyshx changed the title Chore/move visualizer to beta chore(web): move visualizer to beta Jun 1, 2023
@keiya01 keiya01 merged commit 5ed8195 into main Jun 2, 2023
11 of 12 checks passed
@keiya01 keiya01 deleted the chore/move-visualizer-to-beta branch June 2, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants