Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): Add TabButton component #462

Closed
wants to merge 15 commits into from

Conversation

atnagata
Copy link
Contributor

@atnagata atnagata commented Jun 2, 2023

Overview

Add TabButton component

@atnagata atnagata requested a review from KaWaite as a code owner June 2, 2023 02:42
@netlify
Copy link

netlify bot commented Jun 2, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 62bce00
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64795704abff0e0008a8f1fe
😎 Deploy Preview https://deploy-preview-462--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #462 (62bce00) into main (9942876) will increase coverage by 0.03%.
The diff coverage is 92.45%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
+ Coverage   24.63%   24.66%   +0.03%     
==========================================
  Files        1051     1052       +1     
  Lines      112108   112160      +52     
  Branches     2140     2144       +4     
==========================================
+ Hits        27613    27662      +49     
- Misses      83391    83394       +3     
  Partials     1104     1104              
Flag Coverage Δ
web-beta 20.19% <92.45%> (+0.04%) ⬆️
web-classic 20.19% <92.45%> (+0.04%) ⬆️
web-utils 20.19% <92.45%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/beta/components/Icon/icons.ts 0.00% <0.00%> (ø)
web/src/beta/components/TabButton/index.tsx 100.00% <100.00%> (ø)

@keiya01
Copy link
Member

keiya01 commented Jun 2, 2023

ホバーした時の色をactiveの時の色と同じにしていただいても良いでしょうか:pray:
Screenshot 2023-06-02 at 12 43 53

top: 0px;
border-radius: 4px;
:hover {
background: ${({ disabled }) => (disabled ? "#232226" : "lightgrey")};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transition: all 0.5s easeなどとしてアニメーションを入れていただきたいです。

@atnagata atnagata closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants