chore(web): add useManageSwitchState #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
==========================================
+ Coverage 26.72% 26.73% +0.01%
==========================================
Files 1279 1280 +1
Lines 141228 141253 +25
Branches 3436 3440 +4
==========================================
+ Hits 37738 37763 +25
Misses 102369 102369
Partials 1121 1121
Flags with carried forward coverage won't be shown. Click here to find out more.
|
keiya01
reviewed
Jun 7, 2023
Comment on lines
7
to
8
| id: string; | ||
| active: boolean; |
There was a problem hiding this comment.
Suggested change
| id: string; | |
| active: boolean; | |
| name: string; |
I think the props has id and active field in default, so could you set name to this field?
Also could you check if the name field is included in the fields state which is returned from the hooks?
There was a problem hiding this comment.
Added and committed.
keiya01
reviewed
Jun 8, 2023
| @@ -2,6 +2,7 @@ import { useState, useCallback } from "react"; | |||
|
|
|||
| type SwitchField<T> = { | |||
| id: string; | |||
| name?: string; | |||
koji-endo2
pushed a commit
to atnagata/reearth
that referenced
this pull request
Jun 9, 2023
Co-authored-by: 長田淳史 <> Co-authored-by: keiya sasaki <keiya.s.0210@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
add useManageSwitchState
How I tested
Confirmation of activation assuming multiple component (button) state use