Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(web, server): fix blank/null value issue with info #494

Merged
merged 7 commits into from Jun 8, 2023

Conversation

pyshx
Copy link
Contributor

@pyshx pyshx commented Jun 8, 2023

Overview

This PR fixes an issue observed with tags being "blank" instead of null or undefined value.
ref: https://github.com/reearth/reearth/actions/runs/5212511263/jobs/9406193403

@pyshx pyshx requested a review from rot1024 as a code owner June 8, 2023 15:30
@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit 7e97062
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64822f7f8675cd000842fd55

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #494 (7e97062) into main (653523d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #494   +/-   ##
=======================================
  Coverage   26.72%   26.72%           
=======================================
  Files        1279     1279           
  Lines      141228   141228           
  Branches     3436     3436           
=======================================
  Hits        37738    37738           
  Misses     102369   102369           
  Partials     1121     1121           
Flag Coverage Δ
server 36.20% <ø> (ø)
web 24.00% <ø> (ø)
web-beta 24.00% <ø> (ø)
web-classic 24.00% <ø> (ø)
web-utils 24.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pyshx pyshx merged commit 82c0387 into main Jun 8, 2023
18 checks passed
@pyshx pyshx deleted the fix/ci-blank-issue branch June 8, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant