Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): update Beta theme #504

Merged
merged 60 commits into from Jun 19, 2023
Merged

refactor(web): update Beta theme #504

merged 60 commits into from Jun 19, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Jun 14, 2023

Overview

What I've done

  • Went back to using one theme provider
  • temp put classic theme in theme.classic
  • Updated all theme use syntax (most of the files changed)
  • Beta fonts now align with Figma
  • Beta reearthThemes are reduced and a general structure is put in place

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #504 (5963da1) into main (116936c) will increase coverage by 0.67%.
The diff coverage is 30.28%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
+ Coverage   26.01%   26.69%   +0.67%     
==========================================
  Files        1330     1328       -2     
  Lines      144449   144246     -203     
  Branches     3485     3476       -9     
==========================================
+ Hits        37582    38503     +921     
+ Misses     105745   104621    -1124     
  Partials     1122     1122              
Flag Coverage Δ
web 24.02% <30.28%> (+0.85%) ⬆️
web-beta 24.02% <30.28%> (+0.85%) ⬆️
web-classic 24.02% <30.28%> (+0.85%) ⬆️
web-utils 24.02% <30.28%> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/beta/components/Avatar/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Button/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/ContentPicker/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Dropdown/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Loading/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Modal/ModalFrame/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Modal/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Resizable/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Slider/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/SidePanel/index.tsx 0.00% <0.00%> (ø)
... and 247 more

... and 19 files with indirect coverage changes

@KaWaite KaWaite marked this pull request as ready for review June 16, 2023 07:21
@KaWaite KaWaite requested a review from keiya01 as a code owner June 16, 2023 07:21
@github-actions github-actions bot requested a review from isoppp June 16, 2023 07:26
Copy link
Member

@keiya01 keiya01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

web/src/services/i18n/translations/ja.yml Outdated Show resolved Hide resolved
web/src/services/i18n/translations/en.yml Outdated Show resolved Hide resolved
@isoppp isoppp self-requested a review June 19, 2023 02:54
@KaWaite KaWaite merged commit 248f1aa into main Jun 19, 2023
17 checks passed
@KaWaite KaWaite deleted the refactor-beta-themes branch June 19, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants