fix(web): wrong workspace when sharing link #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
- Coverage 26.65% 26.65% -0.01%
==========================================
Files 1336 1336
Lines 144628 144636 +8
Branches 3483 3483
==========================================
Hits 38555 38555
- Misses 104951 104959 +8
Partials 1122 1122
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nina992
changed the title
pyshx
reviewed
Jun 21, 2023
web/src/classic/components/organisms/EarthEditor/Header/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Piyush Chauhan <42397980+pyshx@users.noreply.github.com>
…ong-workspace-when-sharing-link
pyshx
approved these changes
Jun 23, 2023
…ong-workspace-when-sharing-link
KaWaite
approved these changes
Jun 23, 2023
…ong-workspace-when-sharing-link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
when user shares link and then change the workspace , the system returns last workspace instead of the right workspace that project belongs too.
Also I did some refactoring to purge team from system.
Also fix saving workspace when navigate to dashboard
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo