Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): allow reearth_config.json to be set remotely for local development #559

Merged
merged 3 commits into from Jul 6, 2023

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Jul 5, 2023

Overview

You can specify the remote reearth config through an environment variable for development in local env.

REEARTH_WEB_CONFIG_URL="URL for ReEarth config"

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Jul 5, 2023
@keiya01 keiya01 requested a review from KaWaite as a code owner July 5, 2023 07:25
@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 64803c1
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64a538160dcbe400080cb5b4
😎 Deploy Preview https://deploy-preview-559--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Jul 5, 2023
@github-actions github-actions bot requested a review from pyshx July 5, 2023 07:26
@keiya01 keiya01 removed the request for review from pyshx July 5, 2023 07:26
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #559 (64803c1) into main (c603f7b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   27.32%   27.31%   -0.01%     
==========================================
  Files        1345     1345              
  Lines      144972   145014      +42     
  Branches     3541     3541              
==========================================
  Hits        39607    39607              
- Misses     104213   104255      +42     
  Partials     1152     1152              
Flag Coverage Δ
web 24.78% <0.00%> (-0.01%) ⬇️
web-beta 24.78% <0.00%> (-0.01%) ⬇️
web-classic 24.78% <0.00%> (-0.01%) ⬇️
web-utils 24.78% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../classic/components/molecules/Visualizer/index.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@keiya01 keiya01 changed the title chore: fix to fetch the ion token from test env's config chore: Fix to be able to set the remote reearth_config.json for development in local environment Jul 5, 2023
@KaWaite KaWaite changed the title chore: Fix to be able to set the remote reearth_config.json for development in local environment chore(web): allow reearth_config.json to be set remotely for local development Jul 6, 2023
@keiya01 keiya01 merged commit d1cba26 into main Jul 6, 2023
17 of 18 checks passed
@keiya01 keiya01 deleted the chore/local-ion-token branch July 6, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants