Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): panel resize functionality improvements #572

Merged
merged 14 commits into from Jul 19, 2023
Merged

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Jul 11, 2023

Overview

we need to update the panel resizing and add minimizing part to it

What I've done

  • Remove max width- min width
  • Minimized UI
  • On resizing smaller, at 50% initial width auto minimize
  • On clicking min bar, open to initial width again

What I haven't done

How I tested

Which point I want you to review particularly

Memo

https://www.notion.so/eukarya/Update-panel-resize-ceb2b929a18949529b7dfc7343d60c6e

(added by isoppp)
storybook

@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit da4c11d
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64b78d185cc6d000084629e9
😎 Deploy Preview https://deploy-preview-572--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #572 (da4c11d) into main (7622d70) will decrease coverage by 0.01%.
The diff coverage is 2.06%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
- Coverage   28.49%   28.49%   -0.01%     
==========================================
  Files        1392     1392              
  Lines      150308   150357      +49     
  Branches     3590     3590              
==========================================
  Hits        42837    42837              
- Misses     106319   106368      +49     
  Partials     1152     1152              
Flag Coverage Δ
web 26.39% <2.06%> (-0.02%) ⬇️
web-beta 26.39% <2.06%> (-0.02%) ⬇️
web-classic 26.39% <2.06%> (-0.02%) ⬇️
web-utils 26.39% <2.06%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/beta/components/Resizable/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/components/Resizable/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/index.tsx 0.00% <0.00%> (ø)
.../src/services/theme/reearthTheme/common/metrics.ts 100.00% <100.00%> (ø)

@nina992 nina992 marked this pull request as ready for review July 11, 2023 08:58
@nina992 nina992 requested a review from KaWaite as a code owner July 11, 2023 08:58
@github-actions github-actions bot requested a review from isoppp July 11, 2023 08:58
@nina992 nina992 changed the title feat(web): enable panel resizing feat(web): Update panel resize Jul 11, 2023
@KaWaite KaWaite changed the title feat(web): Update panel resize chore(web): panel resize functionality improvements Jul 13, 2023
@nina992 nina992 merged commit 99f5ad8 into main Jul 19, 2023
17 checks passed
@nina992 nina992 deleted the feat/panel-resizing branch July 19, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants