Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): config #575

Merged
merged 7 commits into from Jul 14, 2023
Merged

refactor(web): config #575

merged 7 commits into from Jul 14, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Jul 12, 2023

Overview

config/index was getting a little messy, and the new implementation of AWS's cognito was being handled outside of loadConfig, so this PR refactors config and pulls cognito's configuration together with the rest of config.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@KaWaite KaWaite requested a review from pyshx July 12, 2023 05:17
@netlify
Copy link

netlify bot commented Jul 12, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 8771cf1
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64b0d0e10156d50008e2f72a
😎 Deploy Preview https://deploy-preview-575--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #575 (8771cf1) into main (b1875e6) will decrease coverage by 0.01%.
The diff coverage is 73.88%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
- Coverage   28.49%   28.48%   -0.01%     
==========================================
  Files        1390     1392       +2     
  Lines      150118   150120       +2     
  Branches     3592     3591       -1     
==========================================
- Hits        42771    42769       -2     
- Misses     106195   106199       +4     
  Partials     1152     1152              
Flag Coverage Δ
web 26.38% <73.88%> (-0.01%) ⬇️
web-beta 26.38% <73.88%> (-0.01%) ⬇️
web-classic 26.38% <73.88%> (-0.01%) ⬇️
web-utils 26.38% <73.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/main.tsx 0.00% <ø> (ø)
web/src/services/config/aws.ts 34.04% <34.04%> (ø)
web/src/services/config/index.ts 66.32% <60.00%> (-18.33%) ⬇️
web/src/services/config/defaultConfig.ts 100.00% <100.00%> (ø)
web/src/services/config/passwordPolicy.ts 100.00% <100.00%> (ø)

@KaWaite KaWaite merged commit 2ebdf5f into main Jul 14, 2023
17 checks passed
@KaWaite KaWaite deleted the refactor-aws-config branch July 14, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants