Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): new beta modal design #579

Merged
merged 13 commits into from Jul 24, 2023
Merged

feat(web): new beta modal design #579

merged 13 commits into from Jul 24, 2023

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Jul 13, 2023

Overview

A new design for Modal component - these changes are related to Beta project

What I've done

  • Add the ability to customize Layout.
  • Create header and add (X) close button.
  • Create footer with a divider.
  • check if this new design is fit wherever the modal is used before.
  • Modify the storybook accordingly if needed.

screenshots

imageimage
image
image

What I haven't done

How I tested

Which point I want you to review particularly

Memo

https://www.figma.com/file/W6nDSiCBLubcNeAT6RkOoa/Re%3AEarth-Beta-Design-system?type=design&node-id=256-6282&mode=design

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 919cd8c
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64be32d6a4095200085af909
😎 Deploy Preview https://deploy-preview-579--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #579 (919cd8c) into main (7338624) will decrease coverage by 0.03%.
The diff coverage is 2.40%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
- Coverage   28.36%   28.34%   -0.03%     
==========================================
  Files        1417     1418       +1     
  Lines      152299   152429     +130     
  Branches     3639     3641       +2     
==========================================
+ Hits        43197    43200       +3     
- Misses     107950   108077     +127     
  Partials     1152     1152              
Flag Coverage Δ
web 26.23% <2.40%> (-0.03%) ⬇️
web-beta 26.23% <2.40%> (-0.03%) ⬇️
web-classic 26.23% <2.40%> (-0.03%) ⬇️
web-utils 26.23% <2.40%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/beta/components/Divider/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Modal/ModalFrame/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Modal/index.tsx 0.00% <0.00%> (ø)
web/src/beta/hooks/useManageSwitchState/hooks.tsx 100.00% <100.00%> (ø)

@nina992 nina992 marked this pull request as ready for review July 19, 2023 18:33
@nina992 nina992 requested a review from KaWaite as a code owner July 19, 2023 18:33
@github-actions github-actions bot requested a review from isoppp July 19, 2023 18:33
@nina992 nina992 requested review from keiya01 and removed request for isoppp July 24, 2023 08:23
@nina992 nina992 requested review from pyshx and removed request for keiya01 July 24, 2023 08:28
@nina992 nina992 merged commit 517b1b4 into main Jul 24, 2023
17 checks passed
@nina992 nina992 deleted the feat(web)/modal-beta-design branch July 24, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants