New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): new beta modal design #579
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
- Coverage 28.36% 28.34% -0.03%
==========================================
Files 1417 1418 +1
Lines 152299 152429 +130
Branches 3639 3641 +2
==========================================
+ Hits 43197 43200 +3
- Misses 107950 108077 +127
Partials 1152 1152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
KaWaite
reviewed
Jul 20, 2023
KaWaite
reviewed
Jul 20, 2023
KaWaite
reviewed
Jul 20, 2023
KaWaite
reviewed
Jul 20, 2023
KaWaite
reviewed
Jul 20, 2023
KaWaite
reviewed
Jul 20, 2023
KaWaite
reviewed
Jul 20, 2023
KaWaite
reviewed
Jul 20, 2023
KaWaite
reviewed
Jul 20, 2023
KaWaite
reviewed
Jul 20, 2023
KaWaite
reviewed
Jul 20, 2023
KaWaite
reviewed
Jul 20, 2023
KaWaite
reviewed
Jul 20, 2023
nina992
commented
Jul 21, 2023
KaWaite
reviewed
Jul 24, 2023
KaWaite
reviewed
Jul 24, 2023
…eb)/modal-beta-design
KaWaite
approved these changes
Jul 24, 2023
pyshx
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A new design for Modal component - these changes are related to Beta project
What I've done
screenshots
What I haven't done
How I tested
Which point I want you to review particularly
Memo
https://www.figma.com/file/W6nDSiCBLubcNeAT6RkOoa/Re%3AEarth-Beta-Design-system?type=design&node-id=256-6282&mode=design