Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): Add popover and basic content components #580

Merged
merged 10 commits into from Jul 19, 2023
Merged

Conversation

isoppp
Copy link
Contributor

@isoppp isoppp commented Jul 14, 2023

Overview

Add reusable popover and menu and icons for storytelling left panel.

( The original popover idea/code comes from official example )

What I've done

What I haven't done

  • A pattern that menu has a child menu
  • Use of theme colors

How I tested

  • storybook

https://deploy-preview-580--reearth-web.netlify.app/storybook/?path=/story/beta-components-popover--uncontrolled
https://deploy-preview-580--reearth-web.netlify.app/storybook/?path=/story/beta-components-popover--controlled
https://deploy-preview-580--reearth-web.netlify.app/storybook/?path=/story/beta-components-popovermenucontent--default

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 58647c2
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64b7a4c9d2d5e2000850a3c9
😎 Deploy Preview https://deploy-preview-580--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #580 (22e09a6) into main (99f5ad8) will decrease coverage by 0.05%.
The diff coverage is 2.62%.

❗ Current head 22e09a6 differs from pull request most recent head 58647c2. Consider uploading reports for the commit 58647c2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
- Coverage   28.49%   28.44%   -0.05%     
==========================================
  Files        1392     1397       +5     
  Lines      150357   150613     +256     
  Branches     3590     3595       +5     
==========================================
+ Hits        42837    42845       +8     
- Misses     106368   106616     +248     
  Partials     1152     1152              
Flag Coverage Δ
web 26.34% <2.62%> (-0.06%) ⬇️
web-beta 26.34% <2.62%> (-0.06%) ⬇️
web-classic 26.34% <2.62%> (-0.06%) ⬇️
web-utils 26.34% <2.62%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/beta/components/Popover/context.ts 0.00% <0.00%> (ø)
web/src/beta/components/Popover/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/components/Popover/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Popover/types.ts 0.00% <0.00%> (ø)
...b/src/beta/components/PopoverMenuContent/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Icon/icons.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@isoppp isoppp changed the title chore(web): Add reusable popover chore(web): Add popover and basic content components Jul 17, 2023
@isoppp isoppp marked this pull request as ready for review July 17, 2023 07:19
@isoppp isoppp requested a review from KaWaite as a code owner July 17, 2023 07:19
@github-actions github-actions bot requested a review from nina992 July 17, 2023 07:19
@isoppp isoppp enabled auto-merge (squash) July 19, 2023 08:54
@isoppp isoppp merged commit 53bf82f into main Jul 19, 2023
11 checks passed
@isoppp isoppp deleted the chore/add-popover branch July 19, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants