New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): Add popover and basic content components #580
Conversation
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
==========================================
- Coverage 28.49% 28.44% -0.05%
==========================================
Files 1392 1397 +5
Lines 150357 150613 +256
Branches 3590 3595 +5
==========================================
+ Hits 42837 42845 +8
- Misses 106368 106616 +248
Partials 1152 1152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Overview
Add reusable popover and menu and icons for storytelling left panel.
( The original popover idea/code comes from official example )
What I've done
What I haven't done
How I tested
https://deploy-preview-580--reearth-web.netlify.app/storybook/?path=/story/beta-components-popover--uncontrolled
https://deploy-preview-580--reearth-web.netlify.app/storybook/?path=/story/beta-components-popover--controlled
https://deploy-preview-580--reearth-web.netlify.app/storybook/?path=/story/beta-components-popovermenucontent--default
Which point I want you to review particularly
Memo