Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): create workspace beta modal design #597

Merged
merged 5 commits into from Jul 28, 2023

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Jul 27, 2023

Overview

Create workspace modal design had a side empty space so in this pr I fixed it
image

so the fixed one is :
image

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@nina992 nina992 requested a review from KaWaite as a code owner July 27, 2023 15:27
@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit ae5f49b
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64c3703b164b11000843a9f5
😎 Deploy Preview https://deploy-preview-597--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nina992 nina992 changed the title fix(web):create workspace beta modal design fix(web): create workspace beta modal design Jul 27, 2023
@github-actions github-actions bot added the web label Jul 27, 2023
@github-actions github-actions bot requested a review from isoppp July 27, 2023 15:28
@nina992 nina992 requested a review from airslice July 28, 2023 06:00
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #597 (ae5f49b) into main (714fb91) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #597   +/-   ##
=======================================
  Coverage   28.17%   28.18%           
=======================================
  Files        1419     1419           
  Lines      152573   152494   -79     
  Branches     3637     3637           
=======================================
- Hits        42992    42975   -17     
+ Misses     108425   108367   -58     
+ Partials     1156     1152    -4     
Flag Coverage Δ
web 26.03% <0.00%> (-0.01%) ⬇️
web-beta 26.03% <0.00%> (-0.01%) ⬇️
web-classic 26.03% <0.00%> (-0.01%) ⬇️
web-utils 26.03% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/beta/components/Modal/index.tsx 0.00% <0.00%> (ø)
...a/features/Modals/WorkspaceCreationModal/index.tsx 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@nina992 nina992 merged commit 1410264 into main Jul 28, 2023
17 checks passed
@nina992 nina992 deleted the fix/create-workspace-modal-design branch July 28, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants