Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): add spacing value type with padding and margin UI support #616

Merged
merged 3 commits into from Aug 3, 2023

Conversation

yk-eukarya
Copy link
Contributor

No description provided.

@yk-eukarya yk-eukarya requested a review from pyshx as a code owner August 2, 2023 16:51
@yk-eukarya yk-eukarya self-assigned this Aug 2, 2023
@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit 2474a94
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64cb44ec3985900008106045

@yk-eukarya yk-eukarya requested a review from rot1024 August 2, 2023 16:58
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #616 (2474a94) into main (62d28ed) will decrease coverage by 0.01%.
The diff coverage is 12.65%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
- Coverage   28.43%   28.42%   -0.01%     
==========================================
  Files        1455     1456       +1     
  Lines      158317   158396      +79     
  Branches     3762     3762              
==========================================
+ Hits        45018    45028      +10     
- Misses     112142   112211      +69     
  Partials     1157     1157              
Flag Coverage Δ
server 35.52% <12.65%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../internal/adapter/gql/gqlmodel/convert_property.go 1.23% <0.00%> (-0.07%) ⬇️
server/pkg/property/schema_field_ui.go 85.71% <ø> (ø)
server/pkg/property/value.go 37.34% <ø> (ø)
server/pkg/property/value_spaceing.go 16.94% <16.94%> (ø)

@yk-eukarya yk-eukarya changed the title feat(server): add spacing value type with padding and margin ui support chore(server): add spacing value type with padding and margin UI support Aug 3, 2023
@yk-eukarya yk-eukarya merged commit 99abf5c into main Aug 3, 2023
18 of 19 checks passed
@yk-eukarya yk-eukarya deleted the feat/spacing-value-type branch August 3, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants