Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): import builtin plugin from external url #625

Merged
merged 4 commits into from Aug 8, 2023
Merged

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Aug 7, 2023

Overview

I tried to fix the unsafe builtin plugin system to load the built-in plugin from outside the repository to be more independent.

What I've done

What I haven't done

How I tested

  1. Download builtin-plugin-example.zip
  2. Move to above file
  3. yarn && yarn dev
  4. Move to reearth/server
  5. Set REEARTH_EXT_PLUGIN=http://localhost:5001 in .env for server
  6. Move to reearth/web
  7. Set REEARTH_WEB_UNSAFE_PLUGIN_URLS='["http://localhost:5001/Example.js"]' in .env for web
  8. yarn start
  9. Open Beta project
  10. Go to widget page
  11. Add the widget named Extension

Which point I want you to review particularly

Memo

@keiya01 keiya01 requested a review from airslice August 7, 2023 09:13
@keiya01 keiya01 self-assigned this Aug 7, 2023
@keiya01 keiya01 requested a review from KaWaite as a code owner August 7, 2023 09:13
@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit cf8314e
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64d19ab10a18bb0008b8c6cd
😎 Deploy Preview https://deploy-preview-625--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #625 (cf8314e) into main (d196904) will increase coverage by 0.00%.
The diff coverage is 23.33%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #625   +/-   ##
=======================================
  Coverage   28.43%   28.43%           
=======================================
  Files        1457     1456    -1     
  Lines      158416   158419    +3     
  Branches     3764     3763    -1     
=======================================
+ Hits        45043    45047    +4     
+ Misses     112216   112215    -1     
  Partials     1157     1157           
Flag Coverage Δ
web 26.52% <23.33%> (+<0.01%) ⬆️
web-beta 26.52% <23.33%> (+<0.01%) ⬆️
web-classic 26.52% <23.33%> (+<0.01%) ⬆️
web-utils 26.52% <23.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...b/core/Crust/Infobox/Block/builtin/unsafeBlocks.ts 42.42% <0.00%> (+3.03%) ⬆️
...core/Crust/Widgets/Widget/builtin/unsafeWidgets.ts 0.00% <0.00%> (ø)
web/src/services/config/index.ts 66.66% <20.00%> (-0.99%) ⬇️
web/src/services/config/unsafeBuiltinPlugin.ts 63.88% <31.57%> (-3.86%) ⬇️

@KaWaite KaWaite changed the title fix: import builtin plugin from external url fix(web): import builtin plugin from external url Aug 8, 2023
@keiya01 keiya01 merged commit 17b2566 into main Aug 8, 2023
18 checks passed
@keiya01 keiya01 deleted the fix/builtin-plugin branch August 8, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants