New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): import builtin plugin from external url #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
=======================================
Coverage 28.43% 28.43%
=======================================
Files 1457 1456 -1
Lines 158416 158419 +3
Branches 3764 3763 -1
=======================================
+ Hits 45043 45047 +4
+ Misses 112216 112215 -1
Partials 1157 1157
Flags with carried forward coverage won't be shown. Click here to find out more.
|
KaWaite
reviewed
Aug 8, 2023
KaWaite
reviewed
Aug 8, 2023
KaWaite
changed the title
fix: import builtin plugin from external url
fix(web): import builtin plugin from external url
Aug 8, 2023
KaWaite
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I tried to fix the unsafe builtin plugin system to load the built-in plugin from outside the repository to be more independent.
What I've done
What I haven't done
How I tested
yarn && yarn dev
REEARTH_EXT_PLUGIN=http://localhost:5001
in.env
for serverREEARTH_WEB_UNSAFE_PLUGIN_URLS='["http://localhost:5001/Example.js"]'
in.env
for webyarn start
Extension
Which point I want you to review particularly
Memo