Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): add missing fields for story settings #628

Merged
merged 3 commits into from Aug 12, 2023

Conversation

yk-eukarya
Copy link
Contributor

No description provided.

@yk-eukarya yk-eukarya self-assigned this Aug 10, 2023
@yk-eukarya yk-eukarya requested a review from pyshx as a code owner August 10, 2023 06:05
@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit 659a2a4
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64d72e96f951640008eb94ff

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #628 (659a2a4) into main (8a6ad6a) will increase coverage by 0.03%.
The diff coverage is 48.48%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   28.21%   28.24%   +0.03%     
==========================================
  Files        1473     1473              
  Lines      159870   160021     +151     
  Branches     3780     3780              
==========================================
+ Hits        45107    45202      +95     
- Misses     113606   113663      +57     
+ Partials     1157     1156       -1     
Flag Coverage Δ
server 35.62% <48.48%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ernal/adapter/gql/gqlmodel/convert_storytelling.go 0.00% <0.00%> (ø)
...rnal/adapter/gql/resolver_mutation_storytelling.go 0.00% <0.00%> (ø)
...rnal/infrastructure/mongo/mongodoc/storytelling.go 0.00% <0.00%> (ø)
server/internal/usecase/interactor/storytelling.go 0.00% <0.00%> (ø)
server/pkg/storytelling/block.go 76.92% <100.00%> (+44.42%) ⬆️
server/pkg/storytelling/story.go 81.39% <100.00%> (+20.41%) ⬆️
server/pkg/storytelling/story_bulider.go 100.00% <100.00%> (ø)

server/pkg/storytelling/possision.go Outdated Show resolved Hide resolved
@yk-eukarya yk-eukarya merged commit 75d5223 into main Aug 12, 2023
18 checks passed
@yk-eukarya yk-eukarya deleted the feat/story-settings branch August 12, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants