Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): suppress error in loading built-in plugin #635

Merged
merged 3 commits into from Aug 23, 2023

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Aug 23, 2023

Overview

Re:Earth is logged out when built-in plugin load is failed. So I fixed to suppress the error.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Aug 23, 2023
@keiya01 keiya01 requested a review from KaWaite as a code owner August 23, 2023 00:52
@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 7d95008
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64e5652d4fa0db00087ad469
😎 Deploy Preview https://deploy-preview-635--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Aug 23, 2023
@github-actions github-actions bot requested a review from pyshx August 23, 2023 00:52
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #635 (7d95008) into main (42ad685) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   28.22%   28.22%   -0.01%     
==========================================
  Files        1474     1474              
  Lines      159997   160007      +10     
  Branches     3727     3727              
==========================================
  Hits        45155    45155              
- Misses     113686   113696      +10     
  Partials     1156     1156              
Flag Coverage Δ
web 26.23% <0.00%> (-0.01%) ⬇️
web-beta 26.23% <0.00%> (-0.01%) ⬇️
web-classic 26.23% <0.00%> (-0.01%) ⬇️
web-utils 26.23% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/services/config/unsafeBuiltinPlugin.ts 50.00% <0.00%> (-13.89%) ⬇️

@keiya01 keiya01 merged commit ae83bc0 into main Aug 23, 2023
17 checks passed
@keiya01 keiya01 deleted the fix/supress-built-in-plugin-error branch August 23, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants