Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add env var to specify account database #640

Merged
merged 1 commit into from Aug 24, 2023
Merged

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Aug 24, 2023

Overview

What I've done

Add an env var (REEARTH_DB_ACCOUNT) to specify the database name for accounts, separate from the regular database

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@rot1024 rot1024 requested a review from pyshx as a code owner August 24, 2023 04:43
@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit 8276aab
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64e6e0096946a9000a665d78

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #640 (8276aab) into main (0ef6a88) will decrease coverage by 0.01%.
The diff coverage is 32.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
- Coverage   27.91%   27.91%   -0.01%     
==========================================
  Files        1459     1459              
  Lines      158959   158958       -1     
  Branches     3737     3737              
==========================================
- Hits        44378    44373       -5     
- Misses     113491   113497       +6     
+ Partials     1090     1088       -2     
Flag Coverage Δ
server 35.22% <32.14%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
server/internal/app/config/config.go 43.85% <ø> (ø)
server/internal/app/repo.go 0.00% <0.00%> (ø)
server/internal/infrastructure/mongo/container.go 0.00% <0.00%> (ø)
server/internal/usecase/interactor/dataset.go 0.00% <ø> (ø)
server/internal/usecase/interactor/layer.go 3.51% <ø> (ø)
server/internal/usecase/repo/container.go 37.75% <0.00%> (-2.91%) ⬇️
server/e2e/common.go 67.96% <100.00%> (+2.74%) ⬆️

@rot1024 rot1024 merged commit 3b88ad8 into main Aug 24, 2023
17 of 18 checks passed
@rot1024 rot1024 deleted the dbaccount branch August 24, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant