Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): radio and radio group field components #650

Merged
merged 12 commits into from Sep 8, 2023

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Aug 29, 2023

Overview

Add Radio Box , Radio group to beta version of re-earth

What I've done

  • Create Radio Box component
  • Create Radio Group component
  • Create Radio group field

image
image
image
image
image

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@nina992 nina992 requested a review from KaWaite as a code owner August 29, 2023 06:35
@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 53b0321
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64faba09c65adc0008c28d6d
😎 Deploy Preview https://deploy-preview-650--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Aug 29, 2023
@github-actions github-actions bot requested a review from pyshx August 29, 2023 06:35
@nina992 nina992 changed the title init feat(web): add radio field Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #650 (53b0321) into main (c2c2b06) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
- Coverage   26.78%   26.76%   -0.03%     
==========================================
  Files        1548     1550       +2     
  Lines      169001   169140     +139     
  Branches     3871     3873       +2     
==========================================
  Hits        45262    45262              
- Misses     122650   122789     +139     
  Partials     1089     1089              
Flag Coverage Δ
web 25.04% <0.00%> (-0.03%) ⬇️
web-beta 25.04% <0.00%> (-0.03%) ⬇️
web-classic 25.04% <0.00%> (-0.03%) ⬇️
web-utils 25.04% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../src/beta/components/RadioGroup/RadioBox/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/RadioGroup/index.tsx 0.00% <0.00%> (ø)
📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reearth).

@nina992 nina992 changed the title feat(web): add radio field feat(web): add radio and radio group for beta component Aug 29, 2023
@nina992 nina992 closed this Sep 4, 2023
@nina992 nina992 reopened this Sep 5, 2023
@nina992 nina992 changed the title feat(web): add radio and radio group for beta component chore(web): add radio and radio group for beta component Sep 5, 2023
@nina992 nina992 changed the title chore(web): add radio and radio group for beta component feat(web): add radio and radio group for beta component Sep 5, 2023
@KaWaite KaWaite changed the title feat(web): add radio and radio group for beta component chore(web): radio and radio group field components Sep 6, 2023
@nina992 nina992 merged commit afaa24f into main Sep 8, 2023
17 checks passed
@nina992 nina992 deleted the radio-switch-property-field branch September 8, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants