Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): add story text block #653

Merged
merged 24 commits into from Sep 5, 2023
Merged

chore(web): add story text block #653

merged 24 commits into from Sep 5, 2023

Conversation

airslice
Copy link
Contributor

@airslice airslice commented Sep 3, 2023

Overview

This PR adds story text block.

RichTextEditor is implemented as a third part library component using lexical.

What I've done

  • Add RichTextEditor
  • Add story text block
  • Change story block settings panel as relative element (as design).
  • Change story block basic structure from using children to use render function.

What I haven't done

  • Didn't migrate the RichTextEditor to reearth as a native component.

How I tested

Which point I want you to review particularly

Memo

@github-actions github-actions bot added the web label Sep 3, 2023
@netlify
Copy link

netlify bot commented Sep 3, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 2a7496f
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64f6f5fc783cce0008d2bf98
😎 Deploy Preview https://deploy-preview-653--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #653 (2a7496f) into main (708833b) will decrease coverage by 0.39%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
- Coverage   27.33%   26.95%   -0.39%     
==========================================
  Files        1516     1534      +18     
  Lines      164939   167279    +2340     
  Branches     3843     3861      +18     
==========================================
  Hits        45086    45086              
- Misses     118764   121104    +2340     
  Partials     1089     1089              
Flag Coverage Δ
web 25.26% <0.00%> (-0.46%) ⬇️
web-beta 25.26% <0.00%> (-0.46%) ⬇️
web-classic 25.26% <0.00%> (-0.46%) ⬇️
web-utils 25.26% <0.00%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...es/Editor/StoryPanel/Block/builtin/Text/Editor.tsx 0.00% <0.00%> (ø)
...res/Editor/StoryPanel/Block/builtin/Text/index.tsx 0.00% <0.00%> (ø)
...Editor/StoryPanel/Block/builtin/common/Wrapper.tsx 0.00% <0.00%> (ø)
...es/Editor/StoryPanel/Block/builtin/common/hooks.ts 0.00% <0.00%> (ø)
...nel/Block/builtin/common/usePropertyValueUpdate.ts 0.00% <0.00%> (ø)
web/src/beta/lib/lexical/RichTextEditor/index.tsx 0.00% <0.00%> (ø)
...src/beta/lib/lexical/RichTextEditor/nodes/index.ts 0.00% <0.00%> (ø)
.../lexical/RichTextEditor/plugins/AutoLinkPlugin.tsx 0.00% <0.00%> (ø)
...tEditor/plugins/FloatingLinkEditorPlugin/index.tsx 0.00% <0.00%> (ø)
.../lib/lexical/RichTextEditor/plugins/LinkPlugin.tsx 0.00% <0.00%> (ø)
... and 11 more

... and 3 files with indirect coverage changes

@airslice airslice marked this pull request as ready for review September 3, 2023 12:36
@airslice airslice merged commit 6abb7b0 into main Sep 5, 2023
17 checks passed
@airslice airslice deleted the chore/add-story-text-block branch September 5, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants