Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sever): refactor around NLS layers #656

Merged
merged 2 commits into from Sep 4, 2023
Merged

Conversation

pyshx
Copy link
Contributor

@pyshx pyshx commented Sep 4, 2023

Overview

This PR makes small refactor to mutation made for adding a simple NLS layer.

@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit 0c53de5
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64f547a328b0ef0009610062

@github-actions github-actions bot added the server label Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #656 (0c53de5) into main (69a88d1) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #656   +/-   ##
=======================================
  Coverage   27.33%   27.33%           
=======================================
  Files        1516     1516           
  Lines      164935   164935           
  Branches     3843     3843           
=======================================
  Hits        45086    45086           
  Misses     118760   118760           
  Partials     1089     1089           
Flag Coverage Δ
server 33.74% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...internal/adapter/gql/resolver_mutation_nlslayer.go 0.00% <0.00%> (ø)
server/internal/usecase/interactor/nlslayer.go 0.00% <0.00%> (ø)

@pyshx pyshx merged commit 1405dd6 into main Sep 4, 2023
18 checks passed
@pyshx pyshx deleted the chore/server-refactor-nls branch September 4, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant