Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): publish tab type #659

Merged
merged 9 commits into from Sep 6, 2023
Merged

chore(web): publish tab type #659

merged 9 commits into from Sep 6, 2023

Conversation

mkumbobeaty
Copy link
Contributor

Overview

What I've done

  • Uncomment publish tabs
  • add publish story mutation and update the storytellingApi

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 6709f5d
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64f8454008181f0008be6b4b
😎 Deploy Preview https://deploy-preview-659--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Sep 4, 2023
@mkumbobeaty mkumbobeaty requested review from pyshx and removed request for airslice and pyshx September 4, 2023 14:42
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #659 (6709f5d) into main (caee550) will decrease coverage by 0.01%.
The diff coverage is 24.39%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
- Coverage   26.84%   26.84%   -0.01%     
==========================================
  Files        1545     1546       +1     
  Lines      168497   168565      +68     
  Branches     3869     3869              
==========================================
+ Hits        45228    45245      +17     
- Misses     122180   122231      +51     
  Partials     1089     1089              
Flag Coverage Δ
web 25.13% <24.39%> (-0.01%) ⬇️
web-beta 25.13% <24.39%> (-0.01%) ⬇️
web-classic 25.13% <24.39%> (-0.01%) ⬇️
web-utils 25.13% <24.39%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/beta/features/Editor/tabs/publish/Nav/index.tsx 0.00% <0.00%> (ø)
web/src/services/api/storytellingApi/index.ts 0.00% <0.00%> (ø)
web/src/services/gql/queries/storytelling.ts 0.00% <0.00%> (ø)
web/src/services/api/toGqlStatus.ts 40.00% <40.00%> (ø)
web/src/services/api/projectApi.ts 13.72% <100.00%> (-0.35%) ⬇️
web/src/services/gql/__gen__/gql.ts 100.00% <100.00%> (ø)
web/src/services/gql/__gen__/graphql.ts 100.00% <100.00%> (ø)

@KaWaite KaWaite changed the title feat(web): publish tab type chore(web): publish tab type Sep 6, 2023
@mkumbobeaty mkumbobeaty merged commit feca387 into main Sep 6, 2023
17 checks passed
@mkumbobeaty mkumbobeaty deleted the feat/publish-tab branch September 6, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants