Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): add some atmosphere properties #663

Merged
merged 4 commits into from Sep 6, 2023

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Sep 6, 2023

Overview

I added some scene properties that's used in VIEW3.0.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Sep 6, 2023
@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 5cc196b
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64f84135af45b70008fe2109
😎 Deploy Preview https://deploy-preview-663--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #663 (72c6943) into main (9972e66) will increase coverage by 0.09%.
The diff coverage is 0.00%.

❗ Current head 72c6943 differs from pull request most recent head 5cc196b. Consider uploading reports for the commit 5cc196b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
+ Coverage   26.84%   26.94%   +0.09%     
==========================================
  Files        1545     1535      -10     
  Lines      168478   167355    -1123     
  Branches     3869     3862       -7     
==========================================
- Hits        45228    45086     -142     
+ Misses     122161   121180     -981     
  Partials     1089     1089              
Flag Coverage Δ
web 25.24% <0.00%> (+0.10%) ⬆️
web-beta 25.24% <0.00%> (+0.10%) ⬆️
web-classic 25.24% <0.00%> (+0.10%) ⬆️
web-utils 25.24% <0.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/beta/lib/core/Map/types/index.ts 0.00% <0.00%> (ø)
...eb/src/beta/lib/core/engines/Cesium/core/Globe.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/engines/Cesium/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/engines/Cesium/index.tsx 0.00% <0.00%> (ø)

... and 26 files with indirect coverage changes

Copy link
Contributor

@airslice airslice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just notice we didn't keep the property in same format. I geuss from backend more prefer enable_sun but for frontend we more willing use enableSun. Maybe i made that mis-align in previous PR..Sorry.. Anyway maybe we should refactor them into same format in the future.

@keiya01 keiya01 changed the title feat(web): add some atmosphere properties chore(web): add some atmosphere properties Sep 6, 2023
@keiya01 keiya01 enabled auto-merge (squash) September 6, 2023 09:07
@keiya01 keiya01 merged commit caee550 into main Sep 6, 2023
11 checks passed
@keiya01 keiya01 deleted the feat/add-some-scene-property branch September 6, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants