New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): add some atmosphere properties #663
Conversation
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
==========================================
+ Coverage 26.84% 26.94% +0.09%
==========================================
Files 1545 1535 -10
Lines 168478 167355 -1123
Branches 3869 3862 -7
==========================================
- Hits 45228 45086 -142
+ Misses 122161 121180 -981
Partials 1089 1089
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just notice we didn't keep the property in same format. I geuss from backend more prefer enable_sun
but for frontend we more willing use enableSun
. Maybe i made that mis-align in previous PR..Sorry.. Anyway maybe we should refactor them into same format in the future.
Overview
I added some scene properties that's used in VIEW3.0.
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo