Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): override default light #667

Merged
merged 1 commit into from Sep 7, 2023
Merged

chore(web): override default light #667

merged 1 commit into from Sep 7, 2023

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Sep 7, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Sep 7, 2023
@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 3c9d7ae
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64f9523e9947900008bbfca2
😎 Deploy Preview https://deploy-preview-667--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #667 (3c9d7ae) into main (df854f8) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
- Coverage   26.81%   26.81%   -0.01%     
==========================================
  Files        1547     1547              
  Lines      168724   168734      +10     
  Branches     3870     3870              
==========================================
  Hits        45245    45245              
- Misses     122390   122400      +10     
  Partials     1089     1089              
Flag Coverage Δ
web 25.10% <0.00%> (-0.01%) ⬇️
web-beta 25.10% <0.00%> (-0.01%) ⬇️
web-classic 25.10% <0.00%> (-0.01%) ⬇️
web-utils 25.10% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/beta/lib/core/engines/Cesium/hooks.ts 0.00% <0.00%> (ø)

@keiya01 keiya01 merged commit b3c7e8c into main Sep 7, 2023
17 of 18 checks passed
@keiya01 keiya01 deleted the fix/light branch September 7, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants