New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): fix default infobox behavior #681
Conversation
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we can't just do selectedLayer.layer.layer.infobox ? {title: ....,...,...} : undefined
?
That way we don't have to check visibility or not. Or...do we "hide" the infobox somehow? I don't think in any UI we have a user-facing option for that, but maybe the plugin API has it, and that is why using visible
is best?
Let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, because this is inherited from classic. I'll try it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed your comment.
refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
=======================================
Coverage 26.66% 26.66%
=======================================
Files 1555 1555
Lines 169732 169731 -1
Branches 3878 3878
=======================================
Hits 45262 45262
+ Misses 123381 123380 -1
Partials 1089 1089
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Overview
What I've done
What I haven't done
How I tested
It should not show the infobox
It should show the infobox
Which point I want you to review particularly
Memo