Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): list field #687

Merged
merged 24 commits into from Sep 26, 2023
Merged

chore(web): list field #687

merged 24 commits into from Sep 26, 2023

Conversation

jashanbhullar
Copy link
Contributor

@jashanbhullar jashanbhullar commented Sep 12, 2023

Overview

List field

What I've done

  • created list field with basic logic
  • API integrated
  • Updated PropertyField/index.tsx to accommodate for list fields
  • Updated number field to handle NaN values

What I haven't done

  • You tell me

How I tested

  • stories
  • Editor Ui

Which point I want you to review particularly

  • PropertyField Integration

Memo

  • NA

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit e9ac366
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/651257a1aa5d4500088f901b
😎 Deploy Preview https://deploy-preview-687--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #687 (e9ac366) into main (8c4b5b3) will increase coverage by 0.08%.
The diff coverage is 33.67%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
+ Coverage   28.13%   28.21%   +0.08%     
==========================================
  Files        1568     1569       +1     
  Lines      171094   171518     +424     
  Branches     3820     3818       -2     
==========================================
+ Hits        48144    48401     +257     
- Misses     121861   122028     +167     
  Partials     1089     1089              
Flag Coverage Δ
web 26.88% <33.67%> (+0.10%) ⬆️
web-beta 26.88% <33.67%> (+0.10%) ⬆️
web-classic 26.88% <33.67%> (+0.10%) ⬆️
web-utils 26.88% <33.67%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/components/DragAndDropList/index.tsx 30.00% <100.00%> (+30.00%) ⬆️
web/src/services/gql/__gen__/gql.ts 100.00% <100.00%> (ø)
web/src/services/gql/__gen__/graphql.ts 100.00% <ø> (ø)
web/src/services/gql/queries/property.ts 100.00% <100.00%> (ø)
...eta/components/fields/common/NumberInput/index.tsx 36.12% <0.00%> (-0.39%) ⬇️
web/src/beta/components/Slider/index.tsx 89.85% <12.50%> (-5.60%) ⬇️
...src/beta/components/fields/PropertyFields/hooks.ts 13.95% <3.70%> (-8.27%) ⬇️
web/src/beta/components/fields/ListField/index.tsx 50.00% <50.00%> (ø)
web/src/services/api/propertyApi/index.ts 10.73% <6.74%> (-7.30%) ⬇️
...rc/beta/components/fields/PropertyFields/index.tsx 14.21% <2.70%> (-3.60%) ⬇️

... and 1 file with indirect coverage changes

@jashanbhullar jashanbhullar marked this pull request as ready for review September 25, 2023 09:23
@jashanbhullar jashanbhullar merged commit 07bc841 into main Sep 26, 2023
16 checks passed
@jashanbhullar jashanbhullar deleted the chore/web/list-field branch September 26, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants