Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): story drag and drop #689

Merged
merged 21 commits into from Sep 27, 2023
Merged

feat(web): story drag and drop #689

merged 21 commits into from Sep 27, 2023

Conversation

mkumbobeaty
Copy link
Contributor

Overview

What I've done

  • drag and drop story
  • on scroll the story

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 6c72f50
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6512ada2b547410008c25587
😎 Deploy Preview https://deploy-preview-689--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Sep 14, 2023
@mkumbobeaty mkumbobeaty marked this pull request as ready for review September 14, 2023 01:10
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #689 (6c72f50) into main (a742922) will decrease coverage by 0.02%.
The diff coverage is 11.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   28.21%   28.19%   -0.02%     
==========================================
  Files        1569     1570       +1     
  Lines      171587   171744     +157     
  Branches     3818     3818              
==========================================
+ Hits        48410    48430      +20     
- Misses     122088   122225     +137     
  Partials     1089     1089              
Flag Coverage Δ
web 26.86% <11.50%> (-0.02%) ⬇️
web-beta 26.86% <11.50%> (-0.02%) ⬇️
web-classic 26.86% <11.50%> (-0.02%) ⬇️
web-utils 26.86% <11.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../beta/lib/core/StoryPanel/SelectableArea/index.tsx 43.39% <0.00%> (ø)
web/src/beta/features/Editor/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/Visualizer/index.tsx 0.00% <0.00%> (ø)
...rc/beta/lib/core/StoryPanel/PanelContent/index.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/index.tsx 0.00% <0.00%> (ø)
...src/beta/lib/core/StoryPanel/ActionPanel/index.tsx 51.17% <30.00%> (-0.77%) ⬇️
web/src/beta/features/Editor/useStorytelling.ts 0.00% <0.00%> (ø)
web/src/beta/components/DragAndDropList/Item.tsx 29.75% <27.27%> (+0.50%) ⬆️
web/src/beta/components/DragAndDropList/index.tsx 25.49% <12.00%> (-4.51%) ⬇️
...src/beta/components/DragAndDropList/scrollItem.tsx 17.46% <17.46%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

@mkumbobeaty mkumbobeaty merged commit f0338c8 into main Sep 27, 2023
16 checks passed
@mkumbobeaty mkumbobeaty deleted the storydnd branch September 27, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants