Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): Select field - Minor fixes #696

Merged
merged 4 commits into from Sep 20, 2023

Conversation

jashanbhullar
Copy link
Contributor

@jashanbhullar jashanbhullar commented Sep 19, 2023

Overview

  • Select field minor fixes

What I've done

  • added z-index
  • added reverting arrow icon
  • fixed height
  • added placeholder prop

What I haven't done

NA

How I tested

  • Stories

Which point I want you to review particularly

NA

Memo

NA

@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 38d6093
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/650a7e7ab5659000087bd773
😎 Deploy Preview https://deploy-preview-696--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Sep 19, 2023
@github-actions github-actions bot requested a review from pyshx September 19, 2023 08:11
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #696 (0fad133) into main (b15e426) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 0fad133 differs from pull request most recent head 38d6093. Consider uploading reports for the commit 38d6093 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
- Coverage   26.61%   26.61%   -0.01%     
==========================================
  Files        1560     1560              
  Lines      170247   170256       +9     
  Branches     3886     3886              
==========================================
  Hits        45312    45312              
- Misses     123846   123855       +9     
  Partials     1089     1089              
Flag Coverage Δ
web 24.87% <0.00%> (-0.01%) ⬇️
web-beta 24.87% <0.00%> (-0.01%) ⬇️
web-classic 24.87% <0.00%> (-0.01%) ⬇️
web-utils 24.87% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...b/src/beta/components/fields/SelectField/index.tsx 0.00% <0.00%> (ø)

@jashanbhullar jashanbhullar merged commit 6b5db31 into main Sep 20, 2023
12 checks passed
@jashanbhullar jashanbhullar deleted the chore/web/select-field-fixes branch September 20, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants