Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fix value input asset datatype #698

Merged
merged 4 commits into from Sep 20, 2023

Conversation

pyshx
Copy link
Contributor

@pyshx pyshx commented Sep 20, 2023

Overview

This PR fixes a small bug with adding Asset DataType layer as a Value in Beta.

@pyshx pyshx requested a review from KaWaite as a code owner September 20, 2023 08:37
@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 116e701
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/650ab1c6f25d940008dd619e
😎 Deploy Preview https://deploy-preview-698--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #698 (116e701) into main (70d1dde) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
- Coverage   27.99%   27.99%   -0.01%     
==========================================
  Files        1561     1561              
  Lines      170396   170405       +9     
  Branches     3822     3822              
==========================================
  Hits        47709    47709              
- Misses     121598   121607       +9     
  Partials     1089     1089              
Flag Coverage Δ
web 26.60% <0.00%> (-0.01%) ⬇️
web-beta 26.60% <0.00%> (-0.01%) ⬇️
web-classic 26.60% <0.00%> (-0.01%) ⬇️
web-utils 26.60% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../features/Editor/DataSourceManager/Asset/index.tsx 0.00% <0.00%> (ø)

@pyshx pyshx merged commit bb362bb into main Sep 20, 2023
16 checks passed
@pyshx pyshx deleted the chore/fix-value-input-in-asset branch September 20, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants