Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): Story page camera transition #699

Merged
merged 4 commits into from Sep 21, 2023
Merged

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Sep 21, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit dd22a26
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/650bd9dee796cf00086c3048
😎 Deploy Preview https://deploy-preview-699--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #699 (dd22a26) into main (bb362bb) will increase coverage by 0.00%.
The diff coverage is 1.04%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #699   +/-   ##
=======================================
  Coverage   27.99%   28.00%           
=======================================
  Files        1561     1561           
  Lines      170405   170383   -22     
  Branches     3822     3822           
=======================================
  Hits        47709    47709           
+ Misses     121607   121585   -22     
  Partials     1089     1089           
Flag Coverage Δ
web 26.60% <1.04%> (+<0.01%) ⬆️
web-beta 26.60% <1.04%> (+<0.01%) ⬆️
web-classic 26.60% <1.04%> (+<0.01%) ⬆️
web-utils 26.60% <1.04%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/beta/features/Editor/Visualizer/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/features/Editor/Visualizer/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/features/Editor/index.tsx 0.00% <0.00%> (ø)
.../Editor/tabs/story/LeftPanel/ContentPage/index.tsx 0.00% <0.00%> (ø)
...eta/features/Editor/tabs/story/LeftPanel/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/useLeftPanel.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/useStorytelling.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/Page/index.tsx 0.00% <0.00%> (ø)
...rc/beta/lib/core/StoryPanel/PanelContent/index.tsx 0.00% <0.00%> (ø)
... and 3 more

@KaWaite KaWaite merged commit 4afa473 into main Sep 21, 2023
16 checks passed
@KaWaite KaWaite deleted the actual-story-page-camera branch September 21, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant