Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): workspace policy was not loaded from db correctly #721

Merged
merged 3 commits into from Oct 4, 2023

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Oct 4, 2023

Resolve the problem of the policy not working.

  • The policy ID of workspaces is not loaded correctly from db due to an implementation omission in rearthx (common library)
  • The workspace policy domain model is unique to Re:Earth and should not be included in reearthx, but was included, so it was fixed.

How to test: run locally and check GraphQL response. It returns a policy correctly.

@rot1024 rot1024 requested a review from pyshx as a code owner October 4, 2023 09:29
@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit 00caac6
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/651d37266367ad000825a8c9

@github-actions github-actions bot added the server label Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #721 (00caac6) into main (984e372) will increase coverage by 0.01%.
The diff coverage is 72.85%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #721      +/-   ##
==========================================
+ Coverage   26.70%   26.71%   +0.01%     
==========================================
  Files        1571     1573       +2     
  Lines      171358   171408      +50     
  Branches     3898     3898              
==========================================
+ Hits        45756    45796      +40     
- Misses     124513   124523      +10     
  Partials     1089     1089              
Flag Coverage Δ
server 33.80% <72.85%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
server/internal/adapter/gql/gqlmodel/workspace.go 64.15% <100.00%> (ø)
server/internal/infrastructure/memory/policy.go 90.47% <100.00%> (ø)
...r/internal/infrastructure/mongo/mongodoc/config.go 0.00% <ø> (ø)
server/internal/infrastructure/mongo/policy.go 80.76% <100.00%> (ø)
server/internal/usecase/interactor/layer.go 3.51% <ø> (ø)
server/internal/adapter/gql/loader.go 0.00% <0.00%> (ø)
server/internal/usecase/interactor/common.go 8.95% <0.00%> (-0.07%) ⬇️
server/internal/usecase/interactor/dataset.go 0.00% <0.00%> (ø)
...r/internal/infrastructure/mongo/mongodoc/policy.go 0.00% <0.00%> (ø)
server/internal/adapter/gql/loader_policy.go 0.00% <0.00%> (ø)
... and 2 more

@rot1024 rot1024 changed the title fix(server): policy was fetched from wrong db fix(server): policy was ignored Oct 4, 2023
@rot1024 rot1024 changed the title fix(server): policy was ignored fix(server): workspace policy was not loaded from db correctly Oct 4, 2023
@rot1024 rot1024 merged commit d8022a4 into main Oct 4, 2023
19 checks passed
@rot1024 rot1024 deleted the fix-policy branch October 4, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants