Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): workspace member count is not limited by policies #722

Merged
merged 2 commits into from Oct 4, 2023

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Oct 4, 2023

  • The number of members of workspaces was not limited by policy. It was fixed.
  • Fixed workspace to correctly use default policy.

@rot1024 rot1024 requested a review from pyshx as a code owner October 4, 2023 11:33
@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit cce6bed
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/651d4e82183e030008ec4591

@github-actions github-actions bot added the server label Oct 4, 2023
@rot1024 rot1024 changed the title fix(server): member count is not limited by policies fix(server): workspace member count is not limited by policies Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #722 (cce6bed) into main (d8022a4) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   26.71%   26.71%   -0.01%     
==========================================
  Files        1573     1573              
  Lines      171408   171423      +15     
  Branches     3898     3898              
==========================================
  Hits        45796    45796              
- Misses     124523   124538      +15     
  Partials     1089     1089              
Flag Coverage Δ
server 33.78% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
server/internal/usecase/interactor/common.go 8.95% <0.00%> (ø)
server/internal/app/auth_client.go 0.00% <0.00%> (ø)
server/internal/usecase/interactor/policy.go 0.00% <0.00%> (ø)

@rot1024 rot1024 merged commit 4c7a8f3 into main Oct 4, 2023
17 of 18 checks passed
@rot1024 rot1024 deleted the fix-policy-2 branch October 4, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants