Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): Camera block #729

Merged
merged 25 commits into from Oct 17, 2023
Merged

chore(web): Camera block #729

merged 25 commits into from Oct 17, 2023

Conversation

jashanbhullar
Copy link
Contributor

@jashanbhullar jashanbhullar commented Oct 9, 2023

Overview

Camera Block for storytelling. Combines the following components

  • Camera
  • Button
  • Color Picker

What I've done

  • UI
  • Add Camera button
  • Remove Camera button
  • Move camera button
  • Using visualizer context for flyTo and currentCamera

What I haven't done

  • NA

How I tested

  • UI

Which point I want you to review particularly

  • Handling of API

Memo

- Deleted dropdown
- Deleted MenuList (not being used anymore)
- Add property API works but not UI
- Need to fix update property item
- Need to fix remove property item
- Need to add flyTo camera event
@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit b0d6ce8
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/652d0c2453eed2000978d30f
😎 Deploy Preview https://deploy-preview-729--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #729 (b0d6ce8) into main (c579c63) will decrease coverage by 0.06%.
The diff coverage is 0.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
- Coverage   26.70%   26.65%   -0.06%     
==========================================
  Files        1584     1586       +2     
  Lines      172984   173331     +347     
  Branches     3914     3916       +2     
==========================================
  Hits        46204    46204              
- Misses     125691   126038     +347     
  Partials     1089     1089              
Flag Coverage Δ
web 24.99% <0.52%> (-0.07%) ⬇️
web-beta 24.99% <0.52%> (-0.07%) ⬇️
web-classic 24.99% <0.52%> (-0.07%) ⬇️
web-utils 24.99% <0.52%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/services/api/storytellingApi/blocks.ts 31.91% <100.00%> (+0.58%) ⬆️
...b/core/StoryPanel/Block/builtin/Markdown/index.tsx 0.00% <0.00%> (ø)
...a/lib/core/StoryPanel/Block/builtin/Text/index.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/Block/types.ts 0.00% <0.00%> (ø)
...rc/beta/lib/core/StoryPanel/Block/builtin/index.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/utils.ts 0.00% <0.00%> (ø)
web/src/beta/components/fields/ListField/index.tsx 0.00% <0.00%> (ø)
...Panel/Block/builtin/common/useActionPropertyApi.ts 0.00% <0.00%> (ø)
...lib/core/StoryPanel/Block/builtin/Camera/index.tsx 0.00% <0.00%> (ø)
...ib/core/StoryPanel/Block/builtin/Camera/Editor.tsx 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@KaWaite KaWaite marked this pull request as ready for review October 12, 2023 02:40
@KaWaite KaWaite self-requested a review as a code owner October 12, 2023 02:40
@jashanbhullar jashanbhullar merged commit bac4ba8 into main Oct 17, 2023
16 checks passed
@jashanbhullar jashanbhullar deleted the chore(web)/camera-story-block branch October 17, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants