New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): Camera block #729
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deleted dropdown - Deleted MenuList (not being used anymore)
- Add property API works but not UI - Need to fix update property item - Need to fix remove property item - Need to add flyTo camera event
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
==========================================
- Coverage 26.70% 26.65% -0.06%
==========================================
Files 1584 1586 +2
Lines 172984 173331 +347
Branches 3914 3916 +2
==========================================
Hits 46204 46204
- Misses 125691 126038 +347
Partials 1089 1089
Flags with carried forward coverage won't be shown. Click here to find out more.
|
- Using listifield for cameras - Can also handle move camera buttons order
KaWaite
reviewed
Oct 12, 2023
web/src/beta/lib/core/StoryPanel/Block/builtin/common/usePropertyValueUpdate.ts
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Oct 12, 2023
web/src/beta/lib/core/StoryPanel/Block/builtin/Camera/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Oct 12, 2023
web/src/beta/lib/core/StoryPanel/Block/builtin/Camera/index.tsx
Outdated
Show resolved
Hide resolved
- chaned file name for the updateProperty
KaWaite
reviewed
Oct 17, 2023
KaWaite
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Camera Block for storytelling. Combines the following components
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo